Add new version of OpenMetrics base class #8300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
ofek
force-pushed
the
ofek/openmetrics
branch
17 times, most recently
from
0351b1c
to
d085122
Compare
ofek
force-pushed
the
ofek/openmetrics
branch
3 times, most recently
from
c8e1ac9
to
a8abb62
Compare
ofek
force-pushed
the
ofek/openmetrics
branch
2 times, most recently
from
88acba7
to
e8edb05
Compare
ofek
force-pushed
the
ofek/openmetrics
branch
from
e8edb05
to
c9aeff4
Compare
mgarabed
reviewed
Jan 21, 2021
datadog_checks_base/datadog_checks/base/checks/openmetrics/mixins.py
Outdated
Show resolved
Hide resolved
datadog_checks_base/datadog_checks/base/checks/openmetrics/v2/scraper.py
Show resolved
Hide resolved
datadog_checks_base/datadog_checks/base/checks/openmetrics/v2/scraper.py
Outdated
Show resolved
Hide resolved
datadog_checks_base/datadog_checks/base/checks/openmetrics/v2/scraper.py
Show resolved
Hide resolved
Co-authored-by: Mike Garabedian <[email protected]>
datadog_checks_base/datadog_checks/base/checks/openmetrics/mixins.py
Outdated
Show resolved
Hide resolved
datadog_checks_base/datadog_checks/base/checks/openmetrics/v2/scraper.py
Show resolved
Hide resolved
mgarabed
reviewed
Jan 22, 2021
datadog_checks_base/datadog_checks/base/checks/openmetrics/v2/scraper.py
Show resolved
Hide resolved
datadog_checks_base/datadog_checks/base/checks/openmetrics/v2/transform.py
Show resolved
Hide resolved
mgarabed
approved these changes
Jan 22, 2021
ChristineTChen
approved these changes
Jan 22, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Jan 22, 2021
* Add new version of OpenMetrics base class * Apply suggestions from code review Co-authored-by: Mike Garabedian <[email protected]> * fix typo fix * fix test collection on py2 * update * add larger benchmark * add benchmark for label joins * add comment from feedback * comment Co-authored-by: Mike Garabedian <[email protected]> bed761a
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improve performance & usability and remove legacy code
Additional Notes
Config spec update will be in a separate PR