Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support v2 #8269

Merged
merged 8 commits into from
Jan 4, 2021
Merged

Support v2 #8269

merged 8 commits into from
Jan 4, 2021

Conversation

FlorianVeaux
Copy link
Member

@FlorianVeaux FlorianVeaux commented Dec 29, 2020

Replacement for PR: #8170
Adds a v2 test environment with SSL support and adds test for that version.

The only change in the check code from the other PR is that the check now handles both 401 and 403 error code from the Harbor API for authentication error. The new Harbor API now returns 401 for auth error when it used to return 403.

Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!!

harbor/tox.ini Show resolved Hide resolved
@FlorianVeaux FlorianVeaux merged commit 787eaa6 into master Jan 4, 2021
@FlorianVeaux FlorianVeaux deleted the florian/harbor_v2 branch January 4, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants