Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deployment count metric #8229

Merged
merged 2 commits into from
Dec 21, 2020
Merged

Fix deployment count metric #8229

merged 2 commits into from
Dec 21, 2020

Conversation

mfpierre
Copy link
Contributor

@mfpierre mfpierre commented Dec 21, 2020 •
edited
Loading

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@mfpierre mfpierre requested a review from a team December 21, 2020 17:56
@mfpierre mfpierre requested review from a team as code owners December 21, 2020 17:56
@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #8229 (24d413e) into master (e89af78) will increase coverage by 0.57%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
...atadog_checks/kubernetes_state/kubernetes_state.py 84.54% <ø> (-0.61%) ⬇️
kubernetes_state/tests/test_kubernetes_state.py 97.19% <100.00%> (ø)
iis/tests/common.py
etcd/tests/conftest.py
airflow/tests/conftest.py
postfix/datadog_checks/postfix/__about__.py
envoy/datadog_checks/envoy/__init__.py
elastic/datadog_checks/elastic/metrics.py
couch/datadog_checks/couch/__about__.py
...os_slave/datadog_checks/mesos_slave/mesos_slave.py
... and 865 more

@ChristineTChen ChristineTChen merged commit 46b2780 into master Dec 21, 2020
@ChristineTChen ChristineTChen deleted the mfpierre/fix-deployment-count-metric branch December 21, 2020 20:14
ChristineTChen pushed a commit that referenced this pull request Dec 21, 2020
@mfpierre @ChristineTChen
Fix deployment count metric (#8229)
7e940a8 
* Revert "[orchestrator] change cardinality of deployment count (#8222)"

This reverts commit 9334526.

* use kube_deployment_status_observed_generation to properly count deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaj hkaj hkaj approved these changes

Assignees
No one assigned
Labels
integration/kubernetes_state
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfpierre @hkaj @ChristineTChen