Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix openmetrics integrations config specs #8000

Merged
merged 2 commits into from
Nov 11, 2020
Merged

Fix openmetrics integrations config specs #8000

merged 2 commits into from
Nov 11, 2020

Conversation

ChristineTChen
Copy link
Contributor

What does this PR do?

imports openmetrics template to Prometheus integrations

Motivation

Address errors caught in validation: #7999

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ChristineTChen ChristineTChen requested review from a team as code owners November 10, 2020 18:47
@codecov
Copy link

codecov bot commented Nov 10, 2020 •
edited
Loading

Codecov Report

Merging #8000 (93863d5) into master (d0ccebe) will decrease coverage by 5.56%.
The diff coverage is n/a.

Impacted Files Coverage Δ
mapreduce/datadog_checks/mapreduce/metrics.py
kubelet/tests/test_kubelet.py
kube_apiserver_metrics/tests/common.py
nginx/datadog_checks/nginx/__init__.py
mapr/tests/common.py
fluentd/tests/common.py
lighttpd/tests/conftest.py
..._state/datadog_checks/kubernetes_state/__init__.py
http_check/tests/common.py
cisco_aci/datadog_checks/cisco_aci/helpers.py
... and 855 more

cswatt
cswatt reviewed Nov 10, 2020
View reviewed changes
Copy link
Contributor

@cswatt cswatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no docs review necessary

@ChristineTChen ChristineTChen merged commit 74722c9 into master Nov 11, 2020
@ChristineTChen ChristineTChen deleted the cc/fix-openmetrics-temps branch November 11, 2020 16:08
@ChristineTChen ChristineTChen mentioned this pull request Nov 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cswatt cswatt cswatt left review comments

@yzhan289 yzhan289 yzhan289 approved these changes

Assignees
No one assigned
Labels
documentation integration/azure_iot_edge integration/cilium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristineTChen @cswatt @yzhan289