-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change DB utils behavior when a truncated row is found to only drop the row #7983
Conversation
Codecov Report
|
86490d6
to
ff156cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Should this be changelog/Fixed
at least? There are code and behavioral changes so this needs to appear on the changelog.
CockroachDB
|
@florimondmanca I wasn't sure. If the changelog is for every version of integrations-core, then it should be |
ff156cb
to
9beb3e0
Compare
@justiniso Fair call… In theory the changelog is for users, but in practice it's useful to list all PRs that changed code, even if technically they don't have customer impact (eg because they haven't been exposed to a bug because it had not been released yet). If we need to go back and investigate things then we'll be able to see that there was an initial PR, then one that fixed something missing. |
…he row (#7983) * Change behavior when a truncated row is found to only drop the row * Fix truncation tests
What does this PR do?
For database stats tables, this changes the behavior when a truncated row is found. Because this function computes the difference in monotonic counters between check runs, a value lower than the previous check run is assumed to be invalid. Currently, all rows are dropped when a single row is negative. This can result in states where all rows are dropped every check run due to bad state on a single row.
This was an edge case we caught early on, but forgot about when I opened the PR. I added a comment to avoid making the same mistake again.
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached