Support flush_first_value flag for monotonic counts
#7901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
olivielpeau
previously approved these changes
Oct 30, 2020
Codecov Report
|
yzhan289
reviewed
Oct 30, 2020
| @@ -494,9 +494,17 @@ def monotonic_count(self, name, value, tags=None, hostname=None, device_name=Non | |||
| - **device_name** (_str_) - **deprecated** add a tag in the form `device:<device_name>` to the `tags` | |||
| list instead. | |||
| - **raw** (_bool_) - whether to ignore any defined namespace prefix | |||
| - **flush_first_value** (_bool_) - whether to sample the first value | |||
There was a problem hiding this comment.
If flush_first_value is set to True, does that mean you don't sample the first value?
ofek
force-pushed
the
ofek/mc
branch
4 times, most recently
from
2eaa8ae
to
9610db2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
DataDog/datadog-agent#6663
Additional Notes
The next PR will apply it to the Open Metrics base class