Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better metric names handling when the namespace is empty #7567

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

ahmed-mez
Copy link
Contributor

What does this PR do?

  • Remove the leading dot in metric names when the namespace is empty (e.g .process.vm.bytes -> process.vm.bytes)

Motivation

  • Users might want to pass an empty namespace to the openmetrics check to ease the migration from Prometheus (by having the same metric names in DD)

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

vboulineau
vboulineau previously approved these changes Sep 11, 2020
@ahmed-mez ahmed-mez merged commit 8b03477 into master Sep 11, 2020
@ahmed-mez ahmed-mez deleted the ahmed-mez/fix-openmetrics-ns branch September 11, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants