-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[disk] Add include_all_devices
option and improve error logs
#7378
Conversation
Codecov Report
|
dc85436
to
5c679fe
Compare
79b1843
to
53a6257
Compare
Improve log messages
53a6257
to
ef53636
Compare
It makes no sense to use `file_system_whitelist` in the way previously mentioned, if users want to have more fine grained control they can just specify the lists themselves
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I see that an empty disk/log/.lock
file got added, which can probably be removed.
This does the same that this PR intended but supporting all operating systems and by checking (on Linux) if the file system is backed by a block device.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a comment about the check documentation.
@@ -98,6 +101,14 @@ instances: | |||
# - /dev/sde | |||
# - '[FJ]:' | |||
|
|||
## @param include_all_devices - boolean - optional - default: True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there an uppercase T in True
here, whereas it's lowercase in the spec & in all other config options?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I am not sure why, the conf.yaml.default
file is generated automatically by ddev validate config -s
using the spec.yaml
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's how the config validator works since I added both a default
and an example
value:
integrations-core/datadog_checks_dev/datadog_checks/dev/tooling/configuration/consumers/example.py
Lines 115 to 124 in fda6a83
if 'default' in value: | |
default = value['default'] | |
if default is not None: | |
if type(default) is str: | |
writer.write(' - default: ', default) | |
else: | |
writer.write(' - default: ', repr(default)) | |
else: | |
if example_type is bool: | |
writer.write(' - default: ', 'true' if example else 'false') |
It prints the
repr
of the object (which is True
since that's how it is written in Python) instead of true
or false
, which it does when there is no default
config.
I am going to change it though, since it seems like elsewhere the example
and default
values always match and it can be confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened #7405 to make the behavior consistent.
include_all_devices
option and improve error logs
This way it is more consistent with the rest of options
What does this PR do?
Motivation
Additional Notes
disk_partitions
.Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached