[Couchbase] Properly check the type of the query time values #705
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Properly identify if the value returned is a subclass of the basestring type. Uses
isinstance
instead oftype
astype
doesn't check for inheritance/sub classes, so we never actually hit the convert to seconds function.Motivation
Customer reached out missing the Quey_time based metrics.
Testing Guidelines
An overview on testing
is available in our contribution guidelines.
Versioning
manifest.json
CHANGELOG.md
Additional Notes
Anything else we should know when reviewing?