Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Couchbase] Properly check the type of the query time values #705

Merged
merged 4 commits into from
Aug 25, 2017

Conversation

nmuesch
Copy link
Collaborator

@nmuesch nmuesch commented Aug 24, 2017

What does this PR do?

Properly identify if the value returned is a subclass of the basestring type. Uses isinstance instead of type as type doesn't check for inheritance/sub classes, so we never actually hit the convert to seconds function.

Motivation

Customer reached out missing the Quey_time based metrics.

Testing Guidelines

An overview on testing
is available in our contribution guidelines.

Versioning

  • Bumped the version check in manifest.json
  • Updated CHANGELOG.md

Additional Notes

Anything else we should know when reviewing?

@bits-bot
Copy link
Collaborator

@nmuesch, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gmmeyer to be a potential reviewer.

@nmuesch nmuesch changed the title [Couchbase] Properly check the type of the query time values [Couchbase][WIP] Properly check the type of the query time values Aug 24, 2017
@olivielpeau olivielpeau added this to the 5.17.1 milestone Aug 25, 2017
@nmuesch nmuesch merged commit b331f7e into master Aug 25, 2017
@nmuesch nmuesch deleted the nick/couchbase_fix_query_time_conversion branch August 25, 2017 19:37
@nmuesch nmuesch changed the title [Couchbase][WIP] Properly check the type of the query time values [Couchbase] Properly check the type of the query time values Aug 25, 2017
gml3ff pushed a commit that referenced this pull request May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants