New Integration: Snowflake #7043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristineTChen
force-pushed
the
cc/snowflake
branch
from
059c9fa
to
1bc7d08
Compare
Codecov Report
|
github-actions
bot
added
dev/testing
dependencies
integration/datadog_checks_base
labels
ChristineTChen
force-pushed
the
cc/snowflake
branch
from
3737914
to
e325f73
Compare
ChristineTChen
requested review from
trishankatdatadog and
a team
as code owners
ChristineTChen
force-pushed
the
cc/snowflake
branch
from
50f334b
to
81d759e
Compare
FlorianVeaux
reviewed
Sep 3, 2020
mgarabed
reviewed
Sep 3, 2020
ofek
requested changes
Sep 8, 2020
| type: string | ||
| example: <OCSP_RESPONSE_CACHE_FILENAME> | ||
| - name: metric_groups | ||
| required: true |
There was a problem hiding this comment.
Since there is a default:
Suggested change
| required: true |
WDYT?
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
mgarabed
previously approved these changes
Sep 15, 2020
ofek
approved these changes
Sep 16, 2020
mgarabed
approved these changes
Sep 16, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Sep 16, 2020
* Add snowflake intg * Add dep * Add auth options * Validate config options * set config options * Set up connection obj * Add storage usage query * use dd_check_run fixture * Add execute query * Add metric usage query * Add warehouse credit usage * Collect metadata version * Add mocked test * Add test for metering metrics * override min collection interval * Update * Override min_collect_interval * add metrics * Update last ts * Add test coverage * Add login metrics * Add warehouse load metrics : * fix CI * Pin deps * Add metrics to metadata * Add query history metrics * Get parts from last ts * initial min collection interval * set default for min collect * Add query history metrics * pin dep to 2.1.3 * Ensure queries convert start_time column to UTC * Fix style * Increase latency timestamp to 3 hours * remove last ts concept and collect metrics by day * Update manifest * Add sc * Add readme * Remove conversion and use local time * Add metric groups * Use check_name constant in tests * Test metric group config * Test queries * Clean up * Update billing metrics * Fix style * remove format string from log line * Add test for version metadata * Add data transfer metrics * Add auto recluster metrics * Add table storage metrics * Add pipe metrics * Add replication metrics * Add custom queries * Fix tests * Update readme * Add rec mon * Update with feedback * Add missing option * Update snowflake/requirements-dev.txt Co-authored-by: Ofek Lev <[email protected]> * Update snowflake/datadog_checks/snowflake/queries.py Co-authored-by: Ofek Lev <[email protected]> * Update snowflake/datadog_checks/snowflake/queries.py Co-authored-by: Ofek Lev <[email protected]> * Update snowflake/datadog_checks/snowflake/queries.py Co-authored-by: Ofek Lev <[email protected]> * Update snowflake/datadog_checks/snowflake/queries.py Co-authored-by: Ofek Lev <[email protected]> * Update snowflake/datadog_checks/snowflake/queries.py Co-authored-by: Ofek Lev <[email protected]> * Update snowflake/datadog_checks/snowflake/queries.py Co-authored-by: Ofek Lev <[email protected]> * Update snowflake/datadog_checks/snowflake/queries.py Co-authored-by: Ofek Lev <[email protected]> * Update snowflake/datadog_checks/snowflake/queries.py Co-authored-by: Ofek Lev <[email protected]> * Update snowflake/datadog_checks/snowflake/queries.py Co-authored-by: Ofek Lev <[email protected]> * Update snowflake/datadog_checks/snowflake/queries.py Co-authored-by: Ofek Lev <[email protected]> * Update snowflake/datadog_checks/snowflake/queries.py Co-authored-by: Ofek Lev <[email protected]> * Update snowflake/datadog_checks/snowflake/queries.py Co-authored-by: Ofek Lev <[email protected]> * Make db and schema customizable * Retry connection if closed * clean up Co-authored-by: Ofek Lev <[email protected]> a1b1bc2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached