-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Integration: Snowflake #7043
Conversation
059c9fa
to
1bc7d08
Compare
Codecov Report
|
3737914
to
e325f73
Compare
50f334b
to
81d759e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏅 Very clean and well-organized code!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
type: string | ||
example: <OCSP_RESPONSE_CACHE_FILENAME> | ||
- name: metric_groups | ||
required: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is a default:
required: true |
WDYT?
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
Co-authored-by: Ofek Lev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs approved 👍
* Add snowflake intg * Add dep * Add auth options * Validate config options * set config options * Set up connection obj * Add storage usage query * use dd_check_run fixture * Add execute query * Add metric usage query * Add warehouse credit usage * Collect metadata version * Add mocked test * Add test for metering metrics * override min collection interval * Update * Override min_collect_interval * add metrics * Update last ts * Add test coverage * Add login metrics * Add warehouse load metrics : * fix CI * Pin deps * Add metrics to metadata * Add query history metrics * Get parts from last ts * initial min collection interval * set default for min collect * Add query history metrics * pin dep to 2.1.3 * Ensure queries convert start_time column to UTC * Fix style * Increase latency timestamp to 3 hours * remove last ts concept and collect metrics by day * Update manifest * Add sc * Add readme * Remove conversion and use local time * Add metric groups * Use check_name constant in tests * Test metric group config * Test queries * Clean up * Update billing metrics * Fix style * remove format string from log line * Add test for version metadata * Add data transfer metrics * Add auto recluster metrics * Add table storage metrics * Add pipe metrics * Add replication metrics * Add custom queries * Fix tests * Update readme * Add rec mon * Update with feedback * Add missing option * Update snowflake/requirements-dev.txt Co-authored-by: Ofek Lev <[email protected]> * Update snowflake/datadog_checks/snowflake/queries.py Co-authored-by: Ofek Lev <[email protected]> * Update snowflake/datadog_checks/snowflake/queries.py Co-authored-by: Ofek Lev <[email protected]> * Update snowflake/datadog_checks/snowflake/queries.py Co-authored-by: Ofek Lev <[email protected]> * Update snowflake/datadog_checks/snowflake/queries.py Co-authored-by: Ofek Lev <[email protected]> * Update snowflake/datadog_checks/snowflake/queries.py Co-authored-by: Ofek Lev <[email protected]> * Update snowflake/datadog_checks/snowflake/queries.py Co-authored-by: Ofek Lev <[email protected]> * Update snowflake/datadog_checks/snowflake/queries.py Co-authored-by: Ofek Lev <[email protected]> * Update snowflake/datadog_checks/snowflake/queries.py Co-authored-by: Ofek Lev <[email protected]> * Update snowflake/datadog_checks/snowflake/queries.py Co-authored-by: Ofek Lev <[email protected]> * Update snowflake/datadog_checks/snowflake/queries.py Co-authored-by: Ofek Lev <[email protected]> * Update snowflake/datadog_checks/snowflake/queries.py Co-authored-by: Ofek Lev <[email protected]> * Update snowflake/datadog_checks/snowflake/queries.py Co-authored-by: Ofek Lev <[email protected]> * Make db and schema customizable * Retry connection if closed * clean up Co-authored-by: Ofek Lev <[email protected]> a1b1bc2
What does this PR do?
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached