-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch unicode error #6947
Merged
Merged
Catch unicode error #6947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
ChristineTChen
previously approved these changes
Jun 23, 2020
AlexandreYang
previously approved these changes
Jun 23, 2020
florimondmanca
suggested changes
Jun 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! A couple of polishing (but somewhat important) questions from me…
coignetp
dismissed stale reviews from AlexandreYang and ChristineTChen
via
June 24, 2020 11:08
c44a326
florimondmanca
suggested changes
Jun 24, 2020
florimondmanca
approved these changes
Jun 24, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Jun 24, 2020
* Catch unicode error * Fix typo * Remove useless catches * Add test * Address reviews * Use caplog 89203b6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Catch
UnicodeDecodeError
andUnicodeEncodeError
while getting innodb status.Motivation
Support hotfix while waiting for a feature request to correct this.
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached