Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch unicode error #6947

Merged
merged 6 commits into from
Jun 24, 2020
Merged

Catch unicode error #6947

merged 6 commits into from
Jun 24, 2020

Conversation

coignetp
Copy link
Contributor

@coignetp coignetp commented Jun 23, 2020 •
edited
Loading

What does this PR do?

Catch UnicodeDecodeError and UnicodeEncodeError while getting innodb status.

Motivation

Support hotfix while waiting for a feature request to correct this.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@coignetp coignetp requested a review from a team as a code owner June 23, 2020 09:03
@codecov
Copy link

codecov bot commented Jun 23, 2020 •
edited
Loading

Codecov Report

Merging #6947 into master will decrease coverage by 10.71%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
mysql/datadog_checks/mysql/mysql.py 72.19% <100.00%> (ø)
mysql/tests/test_mysql.py 90.00% <100.00%> (ø)
tcp_check/datadog_checks/tcp_check/tcp_check.py
istio/tests/common.py
...ks_base/datadog_checks/base/stubs/datadog_agent.py
tokumx/tests/conftest.py
amazon_msk/datadog_checks/amazon_msk/amazon_msk.py
teamcity/tests/test_teamcity.py
datadog_checks_base/tests/test_proxy.py
cisco_aci/datadog_checks/cisco_aci/__about__.py
... and 883 more

ChristineTChen
ChristineTChen previously approved these changes Jun 23, 2020
View reviewed changes
AlexandreYang
AlexandreYang previously approved these changes Jun 23, 2020
View reviewed changes
florimondmanca
florimondmanca suggested changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@florimondmanca florimondmanca left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! A couple of polishing (but somewhat important) questions from me…

mysql/tests/common.py Outdated Show resolved Hide resolved
mysql/datadog_checks/mysql/mysql.py Outdated Show resolved Hide resolved
florimondmanca
florimondmanca suggested changes Jun 24, 2020
View reviewed changes
mysql/datadog_checks/mysql/mysql.py Outdated Show resolved Hide resolved
mysql/tests/test_mysql.py Outdated Show resolved Hide resolved
@coignetp coignetp merged commit 89203b6 into master Jun 24, 2020
@coignetp coignetp deleted the paul/mysql-unicode-catch branch June 24, 2020 16:05
github-actions bot pushed a commit that referenced this pull request Jun 24, 2020
@coignetp
Catch unicode error (#6947)
6478e61 
* Catch unicode error

* Fix typo

* Remove useless catches

* Add test

* Address reviews

* Use caplog 89203b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florimondmanca florimondmanca florimondmanca approved these changes

@ChristineTChen ChristineTChen ChristineTChen left review comments

@AlexandreYang AlexandreYang AlexandreYang left review comments

Assignees
No one assigned
Labels
integration/mysql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coignetp @ChristineTChen @florimondmanca @AlexandreYang