Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document join_standard_tags setting in conf.example.yaml #6707

Merged
merged 1 commit into from
May 21, 2020
Merged

Document join_standard_tags setting in conf.example.yaml #6707

merged 1 commit into from
May 21, 2020

Conversation

xornivore
Copy link
Contributor

What does this PR do?

Document join_standard_tags setting in conf.example.yaml.

Motivation

Missing documentation.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@xornivore xornivore requested a review from a team May 21, 2020 16:40
@xornivore xornivore requested a review from a team as a code owner May 21, 2020 16:40
@xornivore xornivore merged commit fd12d78 into master May 21, 2020
@xornivore xornivore deleted the xornivore/ksm-add-doc-for-join-standard-tags-in-yaml-example branch May 21, 2020 17:47
ChristineTChen pushed a commit that referenced this pull request May 22, 2020
@xornivore @ChristineTChen
Add explanation for join_standard_tags setting in conf.example.yaml (#…
5e2661b 
…6707)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlyF CharlyF CharlyF approved these changes

Assignees
No one assigned
Labels
integration/kubernetes_state
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xornivore @CharlyF @ChristineTChen