Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add environment runner for Kubernetes' kind #6522

Merged
merged 23 commits into from
May 13, 2020
Merged

Add environment runner for Kubernetes' kind #6522

merged 23 commits into from
May 13, 2020

Conversation

ChristineTChen
Copy link
Contributor

@ChristineTChen ChristineTChen commented Apr 29, 2020 •
edited
Loading

This PR adds a kind environment runner allowing us to run k8s integrations e2e tests in CI.

Kind spins up a cluster locally with Docker.

This PR also adds:

  • util function to get integration name.
  • Adds kind env runner to cilium
  • Removes terraform references in cilium test

@ChristineTChen ChristineTChen requested a review from a team as a code owner April 29, 2020 02:39
@codecov
Copy link

codecov bot commented Apr 29, 2020 •
edited
Loading

Codecov Report

Merging #6522 into master will decrease coverage by 5.18%.
The diff coverage is 9.43%.

Impacted Files Coverage Δ
cilium/tests/common.py 100.00% <ø> (ø)
datadog_checks_dev/datadog_checks/dev/kind.py 0.00% <0.00%> (ø)
cilium/tests/conftest.py 78.84% <25.00%> (-8.12%) ⬇️
datadog_checks_dev/datadog_checks/dev/utils.py 51.24% <40.00%> (-0.29%) ⬇️
...tadog_checks_dev/datadog_checks/dev/tooling/git.py 83.52% <0.00%> (-2.02%) ⬇️
kube_dns/datadog_checks/kube_dns/__about__.py
ibm_db2/tests/test_unit.py
...e/datadog_checks/base/checks/openmetrics/mixins.py
spark/tests/conftest.py
mapreduce/datadog_checks/mapreduce/mapreduce.py
... and 783 more

@ChristineTChen ChristineTChen changed the title [WIP] Kind environment runner Kind environment runner Apr 29, 2020
ofek
ofek requested changes May 1, 2020
View reviewed changes
datadog_checks_dev/datadog_checks/dev/kind.py Outdated Show resolved Hide resolved
datadog_checks_dev/datadog_checks/dev/kind.py Outdated Show resolved Hide resolved
datadog_checks_dev/datadog_checks/dev/kind.py Outdated Show resolved Hide resolved
datadog_checks_dev/datadog_checks/dev/kind.py Outdated Show resolved Hide resolved
sarah-witt
sarah-witt previously approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ofek
ofek approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ofek ofek changed the title Kind environment runner Add environment runner Kubernetes kind May 13, 2020
@ofek ofek changed the title Add environment runner Kubernetes kind Add environment runner for Kubernetes' kind May 13, 2020
mgarabed
mgarabed approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@mgarabed mgarabed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ChristineTChen ChristineTChen merged commit 53f18aa into master May 13, 2020
@ChristineTChen ChristineTChen deleted the cc/kind-e2e branch May 13, 2020 18:03
@mgarabed mgarabed mentioned this pull request Mar 30, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgarabed mgarabed mgarabed approved these changes

@ofek ofek ofek approved these changes

@sarah-witt sarah-witt sarah-witt left review comments

Assignees
No one assigned
Labels
integration/cilium integration/datadog_checks_dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChristineTChen @mgarabed @ofek @sarah-witt