Add labels_mapper option to kubernetes_state to allow tag renaming #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xvello, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gmmeyer, @olivielpeau and @truthbk to be potential reviewers. |
xvello
force-pushed
the
xvello/kstate_labels_mapper
branch
2 times, most recently
from
d44952e
to
33a0bbc
Compare
hkaj
requested changes
Aug 10, 2017
kubernetes_state/auto_conf.yaml
Outdated
| # Tags are reported as set by kube-state-metrics. If you want to translate | ||
| # them to other tags, you can use the labels_mapper dictionary | ||
| # labels_mapper: | ||
| # namespace: kube_namespace |
There was a problem hiding this comment.
i think the plan for agent 6 is to make init_config optional when it's not needed. And I think the kubernetes_state check only needs one instance, so init_config is unnecessary. If there's no particular reason to keep it here could you move this setting to the instance?
There was a problem hiding this comment.
was planning to do costly processing of the dict on import, but went without at the end. Moving to instance
kubernetes_state/conf.yaml.example
Outdated
| @@ -1,4 +1,10 @@ | |||
| init_config: | |||
| # Tags are reported as set by kube-state-metrics. If you want to translate | |||
xvello
force-pushed
the
xvello/kstate_labels_mapper
branch
from
11a5d68
to
4d7d97b
Compare
xvello
added a commit
to DataDog/docker-dd-agent
that referenced
this pull request
Aug 10, 2017
xvello
force-pushed
the
xvello/kstate_labels_mapper
branch
from
4d7d97b
to
1911403
Compare
hkaj
previously approved these changes
Aug 17, 2017
xvello
force-pushed
the
xvello/kstate_labels_mapper
branch
from
1911403
to
69fac94
Compare
|
Rebase dismissed approval, checks green, force merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows user to set a
labels_mapperoption ininit_configto rename tags from their original prometheus label name to better values. This is based on the existing mechanism inPrometheusCheck, so changes are minimal.Motivation
User request to have metrics tagged with
kube_namespaceinstead ofnamespacefor consistency with the kubernetes check.Versioning
[ ] Bumped the version check inmanifest.jsonCHANGELOG.md