Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break reference cycle with log formatter #6470

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Break reference cycle with log formatter #6470

merged 1 commit into from
Apr 24, 2020

Conversation

therve
Copy link
Contributor

@therve therve commented Apr 24, 2020

Once check_id is set, we don't need to keep the reference to check. It
could help garbage collect check instances.

@therve
Break reference cycle with log formatter
3f1cfe0 
Once check_id is set, we don't need to keep the reference to check. It
could help garbage collect check instances.
@therve therve requested review from a team as code owners April 24, 2020 09:55
@codecov
Copy link

codecov bot commented Apr 24, 2020 •
edited
Loading

Codecov Report

Merging #6470 into master will decrease coverage by 5.73%.
The diff coverage is n/a.

Impacted Files Coverage Δ
...ecks_base/datadog_checks/base/utils/agent/debug.py
squid/tests/common.py
solr/tests/test_check.py
apache/datadog_checks/apache/__about__.py
kubelet/datadog_checks/kubelet/__init__.py
cockroachdb/tests/conftest.py
kyototycoon/tests/conftest.py
...er/datadog_checks/kube_scheduler/kube_scheduler.py
envoy/tests/test_utils.py
..._state/datadog_checks/kubernetes_state/__init__.py
... and 770 more

mgarabed
mgarabed approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@mgarabed mgarabed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed tests seem to be Hazelcast specific, otherwise LGTM 👍

@therve therve merged commit b32fc38 into master Apr 24, 2020
@therve therve deleted the therve/log-cycle branch April 24, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgarabed mgarabed mgarabed approved these changes

Assignees
No one assigned
Labels
integration/datadog_checks_base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@therve @mgarabed