[mysql] Fix bug when options is empty #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@antoinepouille, thanks for your PR! By analyzing the history of the files in this pull request, we identified @truthbk, @gmmeyer and @yannmh to be potential reviewers. |
antoinepouille
force-pushed
the
antoine/fix-mysql-bug-noinnodb-options
branch
from
764f5ac
to
f9936e6
Compare
antoinepouille
force-pushed
the
antoine/fix-mysql-bug-noinnodb-options
branch
from
f9936e6
to
ba6cee8
Compare
hush-hush
requested changes
Jul 28, 2017
mysql/check.py
Outdated
| @@ -322,6 +322,8 @@ def _get_config(self, instance): | |||
| password = str(instance.get('pass', '')) | |||
| tags = instance.get('tags', []) | |||
| options = instance.get('options', {}) | |||
| if options is None: | |||
There was a problem hiding this comment.
options = instance.get('options', {}) or {} would be more pythonic. Also a comment to explain why options might be None would be nice I think.
antoinepouille
force-pushed
the
antoine/fix-mysql-bug-noinnodb-options
branch
from
4c80d84
to
977e90d
Compare
hush-hush
previously approved these changes
Jul 28, 2017
mysql/CHANGELOG.md
Outdated
|
|
||
| ### Changes | ||
|
|
||
| * [BUGFIX] MySQL: Fix bug when options dict is empty. See [637][] |
There was a problem hiding this comment.
No need to repeate MySQL in the changelog for the MySQL check
mysql/CHANGELOG.md
Outdated
| @@ -1,5 +1,12 @@ | |||
| # CHANGELOG - mysql | |||
|
|
|||
| 1.0.4 / UNRELEASED | |||
There was a problem hiding this comment.
We use Unreleased (the tooling it not perfect right now and expect the exact value)
hush-hush
approved these changes
Jul 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The check was running into an issue when the options: section is empty. Changing it to an empty dict instead of a None value.
Motivation
Customer reported this bug.
Versioning
manifest.jsonCHANGELOG.md