Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Convince IDEs and type checkers that
self.instance
always refers to a well-defined instance dict, although it is not technically enforced at runtime yet.Motivation
Currently, mypy always complains (as it should) when we're trying to access anything on
self.instance
, because it's marked asOptional
.This is technically correct, because some tests still use the legacy signature without passing an instance.
But in practice (i.e. when an Agent is running a check in the wild) the
instance
is always set, so it makes better sense to mark it as a non-optional dict.Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached