Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional logging #6128

Merged
merged 3 commits into from
Apr 4, 2020
Merged

Add additional logging #6128

merged 3 commits into from
Apr 4, 2020

Conversation

ian28223
Copy link
Contributor

What does this PR do?

Adds additional logging to help troubleshoot which path is causing the max metrics threshold to be reached

Motivation

2063-error-logging-for-exceeding-max-metric-threshold

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ian28223
Adds some logging
faee9b6 
to determine what path is likely hitting the max allowed metrics
@ian28223 ian28223 requested a review from a team as a code owner March 24, 2020 02:32
@ian28223 ian28223 added the severity/minor Issues that do not affect the functionality of integrations. label Mar 24, 2020
@codecov
Copy link

codecov bot commented Mar 24, 2020 •
edited
Loading

Codecov Report

Merging #6128 into master will increase coverage by 3.59%.
The diff coverage is 66.66%.

Impacted Files Coverage Δ
go_expvar/datadog_checks/go_expvar/go_expvar.py 83.08% <66.66%> (+0.25%) ⬆️
oracle/datadog_checks/oracle/queries.py
cassandra/tests/common.py
directory/datadog_checks/directory/__about__.py
tomcat/datadog_checks/tomcat/__about__.py
openstack_controller/tests/conftest.py
apache/tests/test_apache.py
datadog_checks_dev/tests/test_structures.py
vsphere/datadog_checks/vsphere/legacy/common.py
statsd/datadog_checks/statsd/statsd.py
... and 830 more

@ofek ofek changed the title Adds logging Add additional logging Apr 4, 2020
@mgarabed mgarabed merged commit d5e809f into master Apr 4, 2020
@ian28223 ian28223 deleted the ian.bucad/go_expvar_addlogging branch May 11, 2020 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therve therve therve left review comments

@florimondmanca florimondmanca florimondmanca left review comments

@ofek ofek ofek approved these changes

@ChristineTChen ChristineTChen ChristineTChen approved these changes

Assignees
No one assigned
Labels
integration/go_expvar severity/minor Issues that do not affect the functionality of integrations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ian28223 @therve @ofek @ChristineTChen @florimondmanca @mgarabed