Relax type of ServiceCheck
enum items
#6064
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Relax the type of individual service check enum items, eg
ServiceCheck.OK
, etc.Motivation
Prevent needless type checking nits such as:
error: Incompatible types in assignment (expression has type "Literal[1]", variable has type "Literal[0]")
Eg currently this part of the SNMP check flags red needlessly:
integrations-core/snmp/datadog_checks/snmp/snmp.py
Lines 371 to 376 in f81d305
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached