Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go_expvar.memstats.total_alloc.count #6005

Merged
merged 7 commits into from
Mar 11, 2020
Merged

Add go_expvar.memstats.total_alloc.count #6005

merged 7 commits into from
Mar 11, 2020

Conversation

ChristineTChen
Copy link
Contributor

Previous PR to change total_alloc was reverted because of possible impact to go_expvar.memstats.total_alloc graph oh dashboards (#5972).

This PR allows us to keep compatibility while also submitting the metric correctly as a monotonic count under a new metric name go_expvar.memstats.total_alloc.count

mgarabed
mgarabed previously approved these changes Mar 10, 2020
@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #6005 into master will increase coverage by 4.41%.
The diff coverage is 100%.

Impacted Files Coverage Δ
go_expvar/tests/common.py 100% <100%> (ø) ⬆️
go_expvar/tests/test_unit.py 100% <100%> (ø) ⬆️
go_expvar/datadog_checks/go_expvar/go_expvar.py 82.83% <100%> (+0.39%) ⬆️
go_expvar/tests/test_integration.py 100% <100%> (ø) ⬆️
go_expvar/datadog_checks/go_expvar/__about__.py 100% <0%> (ø) ⬆️
go_expvar/datadog_checks/go_expvar/__init__.py 100% <0%> (ø) ⬆️
go_expvar/tests/conftest.py 100% <0%> (ø) ⬆️
... and 901 more

@ChristineTChen ChristineTChen merged commit 08223ae into master Mar 11, 2020
@ChristineTChen ChristineTChen deleted the cc/go-count branch March 11, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants