PDH to be able to use new agent signature

[hithwen]

Also remove multi instance support. All key based dictionaries have been converted into single lists.
Dictionaries have been left as dictionaries and _make_counters preserves the unused key attribute to prevent breaking IIS check.

Failing integrations Clickhouse, HTTP and TLS are failing on master too

Note: A Bug has been introduced in this PR and the fix is here: #6162

[codecov]

Codecov Report

Merging #5936 into master will increase coverage by 0.75%.
The diff coverage is n/a.

Impacted Files	Coverage Δ
datadog_checks_base/tests/test_pdhbasecheck.py	36.25% <0.00%> (-61.25%)	⬇️
datadog_checks_base/tests/test_winpdh.py	40.81% <0.00%> (-51.03%)	⬇️
datadog_checks_base/tests/test_wmisampler.py	51.21% <0.00%> (-43.91%)	⬇️
disk/tests/common.py	63.63% <0.00%> (-36.37%)	⬇️
disk/tests/conftest.py	85.71% <0.00%> (-11.43%)	⬇️
disk/tests/test_filter.py	96.45% <0.00%> (-3.55%)	⬇️
fluentd/datadog_checks/fluentd/fluentd.py	88.88% <0.00%> (-2.42%)	⬇️
disk/datadog_checks/disk/disk.py	83.88% <0.00%> (-2.07%)	⬇️
fluentd/tests/test_metadata.py	100.00% <0.00%> (ø)
fluentd/tests/test_integration.py	100.00% <0.00%> (ø)
... and 303 more

[ofek]

You'll need to pre-process the args like https://github.com/DataDog/integrations-core/pull/4469/files#diff-09e2f9e4c13710e993b2ce26901f9065

[hithwen]

You'll need to pre-process the args like https://github.com/DataDog/integrations-core/pull/4469/files#diff-09e2f9e4c13710e993b2ce26901f9065

Shouldn't AgentCheck be in charge of that?

[hithwen]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ofek]

asp is failing

[ofek]

Need to extract things before super() like:

integrations-core/datadog_checks_base/datadog_checks/base/checks/openmetrics/base_check.py

Lines 46 to 58 in 8b2ed4d

	args = list(args)
	default_instances = kwargs.pop('default_instances', None) or {}
	default_namespace = kwargs.pop('default_namespace', None)
	legacy_kwargs_in_args = args[4:]
	del args[4:]
	if len(legacy_kwargs_in_args) > 0:
	default_instances = legacy_kwargs_in_args[0] or {}
	if len(legacy_kwargs_in_args) > 1:
	default_namespace = legacy_kwargs_in_args[1]
	super(OpenMetricsBaseCheck, self).__init__(*args, **kwargs)

[hithwen]

Need to extract things before super() like:

integrations-core/datadog_checks_base/datadog_checks/base/checks/openmetrics/base_check.py

Lines 46 to 58 in 8b2ed4d

	args = list(args)
	default_instances = kwargs.pop('default_instances', None) or {}
	default_namespace = kwargs.pop('default_namespace', None)
	legacy_kwargs_in_args = args[4:]
	del args[4:]
	if len(legacy_kwargs_in_args) > 0:
	default_instances = legacy_kwargs_in_args[0] or {}
	if len(legacy_kwargs_in_args) > 1:
	default_namespace = legacy_kwargs_in_args[1]
	super(OpenMetricsBaseCheck, self).__init__(*args, **kwargs)

Does it make a difference to do it before or after?