-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDH to be able to use new agent signature #5936
Conversation
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to pre-process the args like https://github.com/DataDog/integrations-core/pull/4469/files#diff-09e2f9e4c13710e993b2ce26901f9065
Shouldn't AgentCheck be in charge of that? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
asp is failing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to extract things before super()
like:
integrations-core/datadog_checks_base/datadog_checks/base/checks/openmetrics/base_check.py
Lines 46 to 58 in 8b2ed4d
args = list(args) | |
default_instances = kwargs.pop('default_instances', None) or {} | |
default_namespace = kwargs.pop('default_namespace', None) | |
legacy_kwargs_in_args = args[4:] | |
del args[4:] | |
if len(legacy_kwargs_in_args) > 0: | |
default_instances = legacy_kwargs_in_args[0] or {} | |
if len(legacy_kwargs_in_args) > 1: | |
default_namespace = legacy_kwargs_in_args[1] | |
super(OpenMetricsBaseCheck, self).__init__(*args, **kwargs) |
Does it make a difference to do it before or after? |
58ff425
to
69fd749
Compare
Also remove multi instance support. All key based dictionaries have been converted into single lists.
Dictionaries have been left as dictionaries and _make_counters preserves the unused key attribute to prevent breaking IIS check.
Failing integrations Clickhouse, HTTP and TLS are failing on master too
Note: A Bug has been introduced in this PR and the fix is here: #6162