Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md and example log section #5898

Merged
merged 5 commits into from
Feb 27, 2020
Merged

Update README.md and example log section #5898

merged 5 commits into from
Feb 27, 2020

Conversation

AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented Feb 27, 2020

What does this PR do?

  1. Update README.md log section to be more consistent with other integrations.

  2. Remove instance and init_config from conf.yaml.example since those are not necessary for a log only integration. It also avoids the agent displaying this error:

  Loading Errors
  ==============
    tenable
    -------
      Core Check Loader:
        Check tenable not found in Catalog

      JMX Check Loader:
        check is not a jmx check, or unable to determine if it's so

      Python Check Loader:
        unable to import module 'tenable': No module named 'tenable'
  1. Since this is a logs integration. Let's uncomment the logs section in conf.yaml.example

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

Copy link
Contributor

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost all good — small copy nit.

tenable/README.md Outdated Show resolved Hide resolved
Co-Authored-By: Florimond Manca <[email protected]>
@ofek ofek changed the title Update README.md log section Update README.md and example log section Feb 27, 2020
@ofek ofek merged commit 1ea360d into master Feb 27, 2020
@ofek ofek deleted the alex/tenable_doc branch February 27, 2020 15:49
ofek pushed a commit that referenced this pull request Feb 27, 2020
* Update README.md log section

* Clean up conf.yaml.example

* Fix typo

* Uncomment logs section

* Update tenable/README.md

Co-Authored-By: Florimond Manca <[email protected]>

Co-authored-by: Florimond Manca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants