Make `is_metadata_collection_enabled` static #5863

AlexandreYang · 2020-02-25T15:01:07Z

is_metadata_collection_enabled can be static

codecov · 2020-02-25T15:06:48Z

Codecov Report

Merging #5863 into master will decrease coverage by 0.57%.
The diff coverage is n/a.

Impacted Files	Coverage Δ
disk/tests/common.py	`63.63% <0.00%> (-36.37%)`	⬇️
disk/tests/conftest.py	`85.71% <0.00%> (-11.43%)`	⬇️
disk/tests/test_filter.py	`96.45% <0.00%> (-3.55%)`	⬇️
disk/datadog_checks/disk/disk.py	`83.88% <0.00%> (-2.07%)`	⬇️
couch/datadog_checks/couch/couch.py	`88.21% <0.00%> (-1.15%)`	⬇️
openldap/datadog_checks/openldap/__init__.py
envoy/datadog_checks/envoy/utils.py
cacti/tests/test_cacti.py
mesos_master/tests/test_integration.py
ibm_mq/tests/test_ibm_mq.py
... and 366 more

Make is_metadata_collection_enabled static

c38c174

AlexandreYang requested review from a team as code owners February 25, 2020 15:01

github-actions bot added the integration/datadog_checks_base label Feb 25, 2020

AlexandreYang changed the title ~~Make is_metadata_collection_enabled static~~ [HOLD] Make is_metadata_collection_enabled static Feb 27, 2020

AlexandreYang added the changelog/Fixed label Mar 1, 2020

AlexandreYang changed the title ~~[HOLD] Make is_metadata_collection_enabled static~~ Make is_metadata_collection_enabled static Mar 1, 2020

FlorianVeaux approved these changes Mar 5, 2020

View reviewed changes

ofek added changelog/Added and removed changelog/Fixed labels Mar 5, 2020

ofek approved these changes Mar 5, 2020

View reviewed changes

hithwen approved these changes Mar 5, 2020

View reviewed changes

AlexandreYang merged commit e930265 into master Mar 5, 2020

AlexandreYang deleted the alex/make_is_metadata_collection_enabled_static branch March 5, 2020 21:05