-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not fail on octet stream content type for OpenMetrics #5843
Merged
AlexandreYang
merged 5 commits into
master
from
alex/fix_openmetrics_octet_stream_content_type
Mar 2, 2020
Merged
Do not fail on octet stream content type for OpenMetrics #5843
AlexandreYang
merged 5 commits into
master
from
alex/fix_openmetrics_octet_stream_content_type
Mar 2, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
Closing in favour of #5847 |
AlexandreYang
restored the
alex/fix_openmetrics_octet_stream_content_type
branch
February 28, 2020 10:30
AlexandreYang
changed the title
Do not fail on octet stream content type
Do not fail on octet stream content type1
Feb 28, 2020
AlexandreYang
changed the title
Do not fail on octet stream content type1
[HOLD] Do not fail on octet stream content type1
Feb 28, 2020
AlexandreYang
force-pushed
the
alex/fix_openmetrics_octet_stream_content_type
branch
from
February 28, 2020 10:32
3603417
to
eb2699a
Compare
AlexandreYang
changed the title
[HOLD] Do not fail on octet stream content type1
[HOLD] Do not fail on octet stream content type
Feb 28, 2020
AlexandreYang
changed the title
[HOLD] Do not fail on octet stream content type
Do not fail on octet stream content type
Feb 28, 2020
mgarabed
reviewed
Feb 28, 2020
ofek
requested changes
Feb 28, 2020
ofek
approved these changes
Feb 28, 2020
xornivore
approved these changes
Mar 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
4 tasks
ofek
changed the title
Do not fail on octet stream content type
Do not fail on octet stream content type for OpenMetrics
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
utf-8
when there is no encoding to avoid failure down the road.Content might be in bytes when the service exposing the openmetrics endpoint doesn't set correctly the Content-Type and Encoding.
The openmetrics/prometheus exposition format suggest using
utf-8
: https://github.com/prometheus/docs/blob/master/content/docs/instrumenting/exposition_formats.mdtext/plain
Motivation
Currently, if
bytes
content is received. In Python 3 (works for Python 2), the openmetrics check will fail with the following issue:Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached