Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade virtualenv dependency to 20.x #5680

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

florimondmanca
Copy link
Contributor

@florimondmanca florimondmanca commented Feb 10, 2020

What does this PR do?

Pin dependency on virtualenv to 20.*.

Motivation

Additional Notes

Validated on a fresh install:

# Upgrade ddev, which installs new `virtualenv`.
pip install -U -e "./datadog_checks_dev[cli]"

# Nuke existing virtualenvs in an integration (pick any)
rm -r http_check/.tox

# Run tests, which will recreate venvs with `virtualenv` 20.x.
ddev test http_check

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@florimondmanca florimondmanca requested a review from ofek February 10, 2020 14:27
@florimondmanca florimondmanca requested a review from a team as a code owner February 10, 2020 14:27
@florimondmanca florimondmanca changed the title Upgrade to virtualenv 20.x Upgrade virtualenv dependency to 20.x Feb 10, 2020
@codecov
Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #5680 into master will decrease coverage by 4.72%.
The diff coverage is n/a.

Impacted Files Coverage Δ
datadog_checks_dev/datadog_checks/dev/__main__.py 100.00% <0.00%> (ø) ⬆️
datadog_checks_dev/tests/common.py 100.00% <0.00%> (ø) ⬆️
datadog_checks_dev/tests/conftest.py 100.00% <0.00%> (ø) ⬆️
datadog_checks_dev/tests/test__env.py 100.00% <0.00%> (ø) ⬆️
datadog_checks_dev/tests/test_docker.py 100.00% <0.00%> (ø) ⬆️
datadog_checks_dev/tests/test_conditions.py 100.00% <0.00%> (ø) ⬆️
datadog_checks_dev/tests/test_structures.py 100.00% <0.00%> (ø) ⬆️
datadog_checks_dev/tests/test_subprocess.py 100.00% <0.00%> (ø) ⬆️
datadog_checks_dev/datadog_checks/dev/env.py 43.18% <0.00%> (ø) ⬆️
datadog_checks_dev/tests/tooling/test_git.py 100.00% <0.00%> (ø) ⬆️
... and 889 more

@florimondmanca
Copy link
Contributor Author

florimondmanca commented Feb 10, 2020

Note: some users are experiencing issues with v20: pypa/virtualenv#1551.

But it looks like we're not affected. (Validated that virtualenv creation and tests run fine on a fresh install -- see updated PR description. Also the PR Changes job here successfully got Tox to create a venv for 2.7 and 3.8.)

@florimondmanca florimondmanca merged commit 86ae3c9 into master Feb 10, 2020
@florimondmanca florimondmanca deleted the florimondmanca/upgrade-virtualenv branch February 10, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants