Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix service check "topic" tag #5679

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Conversation

FlorianVeaux
Copy link
Member

@FlorianVeaux FlorianVeaux commented Feb 10, 2020

The mapr.can_connect service check is sent with the topic tag but in one place this tag is called topic_path. Let's fix the mistake.

Impact would be minimal as I doubt anyone tried to set up a monitor on mapr.can_connect by {topic_path}, knowing that:

  • the backend doesn't know about that tag so you would have to create a custom check monitor instead of an integration monitor.
  • This tag only appears when the MapR endpoint doesn't work.

@FlorianVeaux FlorianVeaux requested a review from a team as a code owner February 10, 2020 13:48
@FlorianVeaux FlorianVeaux changed the title Fix service check tag Fix service check "topic" tag Feb 10, 2020
@FlorianVeaux FlorianVeaux merged commit 15c76d3 into master Feb 10, 2020
@FlorianVeaux FlorianVeaux deleted the florian/fix_mapr_service_checl branch February 10, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants