Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly cast max_returned_metrics option to an integer #5536

Merged
merged 4 commits into from
Jan 27, 2020
Merged

Properly cast max_returned_metrics option to an integer #5536

merged 4 commits into from
Jan 27, 2020

Conversation

ChristineTChen
Copy link
Contributor

@ChristineTChen ChristineTChen commented Jan 23, 2020 •
edited
Loading

What does this PR do?

max_returned_metric throws TypeError when yaml value is a string.

Motivation

Fixes #5534

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ChristineTChen ChristineTChen requested review from a team as code owners January 23, 2020 16:35
@ChristineTChen ChristineTChen changed the title Fix Python3 type error for string int config value Fix Python3 TypeError for string int config value Jan 23, 2020
@ChristineTChen ChristineTChen changed the title Fix Python3 TypeError for string int config value Fix Python3 TypeError for max_returned_metric Jan 23, 2020
therve
therve previously approved these changes Jan 23, 2020
View reviewed changes
@ofek ofek changed the title Fix Python3 TypeError for max_returned_metric Properly cast max_returned_metrics option to an integer Jan 23, 2020
@ChristineTChen ChristineTChen merged commit a6d5b1c into master Jan 27, 2020
@ChristineTChen ChristineTChen deleted the cc/base-int branch January 27, 2020 16:31
ofek pushed a commit that referenced this pull request Jan 30, 2020
@ChristineTChen @ofek
Properly cast max_returned_metrics option to an integer (#5536)
8434c3f 
* Cast int to max_returned_metrics

* add test

* fix style

* use self.instance
AlexandreYang pushed a commit that referenced this pull request Jan 30, 2020
@ChristineTChen @AlexandreYang
Properly cast max_returned_metrics option to an integer (#5536)
6b2e4a0 
* Cast int to max_returned_metrics

* add test

* fix style

* use self.instance
@FlorianVeaux FlorianVeaux mentioned this pull request Feb 10, 2020
Closed
@florimondmanca florimondmanca mentioned this pull request Feb 26, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgarabed mgarabed mgarabed approved these changes

@therve therve therve left review comments

Assignees
No one assigned
Labels
integration/datadog_checks_base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[base] metric_limit fails due to missing type cast on Python 3
4 participants
@ChristineTChen @therve @mgarabed @ofek