Add ability to submit time deltas to database query utility #5524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
mgarabed
requested changes
Jan 22, 2020
| # Prevent naive datetime objects | ||
| if dt.tzinfo is None: | ||
| # The stdlib datetime.timezone.utc doesn't work properly on Windows | ||
| dt = dt.replace(tzinfo=pytz.utc) |
There was a problem hiding this comment.
We are assuming that since this is coming from a database, its most likely UTC which makes sense.
There are occasions if we have a naive timestamp that we should normalize to local timezone instead, maybe an opportunity for a future PR timeutils module.
An implementation I have used in the past which has been quite handy: https://github.com/riverbed/steelscript/blob/af4405c63f378db5466397fd566beb8226edf647/steelscript/common/timeutils.py#L52
mgarabed
approved these changes
Jan 22, 2020
therve
approved these changes
Jan 22, 2020
AlexandreYang
pushed a commit
that referenced
this pull request
Jan 30, 2020
* Add ability to submit time deltas to database query utility * address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Many integrations do that