-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix http handler #5434
Fix http handler #5434
Conversation
Codecov Report
|
@@ -57,7 +57,7 @@ def __init__(self, *args, **kwargs): | |||
|
|||
super(OpenMetricsBaseCheck, self).__init__(*args, **kwargs) | |||
self.config_map = {} | |||
self.http_handlers = {} | |||
self._http_handlers = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Let's not expose the http handlers and use get_http_handler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9f3b5f8
to
2f6b2e8
Compare
What does this PR do?
Before, if the
prometheus_url
is changed after the scrapper is created, we won't be able to find the handler. Hence leading to aKeyError
.Initial feature PR: #5414
Example:
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached