Update SNMP requirements #5234
Merged
Update SNMP requirements #5234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates pysnmp and its dependencies. We can't update pyasn1 for now because of etingof/pyasn1#178. And we can't update pysnmp to 4.4.10+ because of etingof/pysnmp#329.
therve
force-pushed
the
therve/snmp-bump-req
branch
from
8127de6
to
9eafe18
Compare
Codecov Report
|
AlexandreYang
previously approved these changes
Dec 18, 2019
| @@ -1,7 +1,7 @@ | |||
| ipaddress==1.0.22; python_version < '3.0' | |||
| ply==3.10 | |||
| pyasn1==0.4.6 | |||
There was a problem hiding this comment.
(nit)
We can't update pyasn1 for now
because of etingof/pyasn1#178. And we can't
update pysnmp to 4.4.10+ because of etingof/pysnmp#329.
Could you inline those comments in the requirements.in. That might be helpful.
AlexandreYang
approved these changes
Dec 18, 2019
florimondmanca
added
changelog/Added
and removed
changelog/no-changelog
changelog/Added
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates pysnmp and its dependencies. We can't update pyasn1 for now
because of etingof/pyasn1#178. And we can't
update pysnmp to 4.4.10+ because of etingof/pysnmp#329.