-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use RequestsWrapper #5037
Use RequestsWrapper #5037
Conversation
self.appcenter = False | ||
if sessions is None: | ||
self.sessions = [] | ||
self.appcenter = appcenter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a possible fix.
Codecov Report
|
cisco_aci/tests/common.py
Outdated
3. Returns the corresponding file content | ||
""" | ||
|
||
fixture_dirs = ALL_FICTURE_DIR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe we can fix the typo while we're here
@@ -5,6 +5,7 @@ envlist = | |||
py{27,37} | |||
|
|||
[testenv] | |||
usedevelop = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice refactor! Just needs a rebase
cdf77ea
to
18865b8
Compare
This uses the request wrapper instead of sessions directly, and tries to
simplify the tests.