Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kafka_client_api_version #5007

Merged
merged 7 commits into from
Dec 9, 2019
Merged

Conversation

ian28223
Copy link
Contributor

What does this PR do?

fixes an issue when pinning the api_version.

2 issues:

  • api_version expects a tuple but kafka_client_api_version is a string
  • there is a bug with KafkaAdminClient where pinning any api_version will raise an IncompatibleBrokerVersion. Setting api_version=None would be a temporary fix.

Motivation

found bug while investigating something.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

each instance could potentially have different api_versions, connections, etc
@hithwen hithwen requested a review from ofek November 20, 2019 12:20
@ian28223
Copy link
Contributor Author

Alternatively, can we path kafka-python the same as how we did it with jaydebeapi (DataDog/datadog-agent#4402)?

we just need to insert 1 line at kafka/admin/client.py https://github.com/dpkp/kafka-python/pull/1953/files
then we can keep pinning the api_version in https://github.com/DataDog/integrations-core/pull/5007/files#diff-deed983f73a04522ac621d7f6d0c8403R132-R133

@hithwen hithwen self-assigned this Nov 29, 2019
@ofek ofek changed the title fix kafka_client_api_version Fix kafka_client_api_version Nov 29, 2019
@ofek ofek merged commit 6cb1365 into master Dec 9, 2019
@ofek ofek deleted the ian.bucad/kafka_consumer_version_debug branch December 9, 2019 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants