Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support downloading universal and pure Python wheels #4981

Merged
merged 13 commits into from
Nov 27, 2019

Conversation

trishankatdatadog
Copy link
Member

What does this PR do?

New downloader for new Agents that will download and verify both universal and pure Python wheels.

Motivation

Request to support both types of wheels.

Additional Notes

This only affects new Agents. Old downloaders in old Agents will continue to work.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@trishankatdatadog
Copy link
Member Author

Right now, the integration test running the downloader on every integration will fail, saying something like:

tuf.exceptions.UnknownTargetError: u'in-toto-metadata/2.root.layout' not found.

This is because the repository has not been updated with this new root layout yet. We should be doing that early next week.

@codecov
Copy link

codecov bot commented Nov 23, 2019

Codecov Report

Merging #4981 into master will decrease coverage by 1.23%.
The diff coverage is n/a.

Impacted Files Coverage Δ
datadog_checks_base/tests/conftest.py 33.33% <0%> (-66.67%) ⬇️
...atadog_checks_base/datadog_checks/base/__init__.py 73.33% <0%> (-13.34%) ⬇️
datadog_checks_base/tests/test_winpdh.py 90.9% <0%> (-6.82%) ⬇️
datadog_checks_base/datadog_checks/base/ddyaml.py 56.71% <0%> (-4.48%) ⬇️
datadog_checks_base/tests/test_http.py 94.39% <0%> (-4.01%) ⬇️
datadog_checks_base/tests/test_pdhbasecheck.py 96% <0%> (-4%) ⬇️
clickhouse/datadog_checks/clickhouse/clickhouse.py
vertica/tests/metrics.py
fluentd/tests/test_metadata.py
rabbitmq/tests/test_rabbitmq.py
... and 304 more

ofek
ofek previously approved these changes Nov 27, 2019
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@ofek
Copy link
Contributor

ofek commented Nov 27, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@trishankatdatadog
Copy link
Member Author

trishankatdatadog commented Nov 27, 2019

OK, we look good to go 🚀

Just to clarify, this is for datadog-agent>=6.16.0.

Also, could we please bump the datadog-checks-downloader from 0.6.0 to 2.0.0? This is to make it sparkling clear that this version of the downloader is explicitly tied to v2 of our software supply chain (2.root.layout), which requires supplying the Python tag when verifying a wheel.

@ofek ofek merged commit 366b244 into master Nov 27, 2019
@ofek ofek deleted the trishankatdatadog/py2-or-py3 branch November 27, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants