Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix job metrics #4943

Merged
merged 5 commits into from
Nov 19, 2019
Merged

Fix job metrics #4943

merged 5 commits into from
Nov 19, 2019

Conversation

Simwar
Copy link
Contributor

@Simwar Simwar commented Nov 4, 2019

What does this PR do?

The last change did not include a code path for jobs, only for cron jobs.
Also, there was an issue when the value of the succeeded/failed metric was set to 0, before being set to 1.

Motivation

Several customers reported missing values

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@Simwar Simwar requested review from a team as code owners November 4, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants