Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to jaydebeapi 1.1.2 #4934

Closed
wants to merge 2 commits into from

Conversation

jtran1209
Copy link

@jtran1209 jtran1209 commented Oct 30, 2019

What does this PR do?

Sets the oracle requirements.in and base agent_requirements.in to use jaydebeapi 1.1.2 from source code.

Motivation

The maintainer of JayDeBeApi has committed version 1.1.2 which fixes compatibility with JPype 0.7.0, however they are unable to publish to PyPi at this time.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@jtran1209 jtran1209 requested review from a team as code owners October 30, 2019 23:53
@hithwen
Copy link
Contributor

hithwen commented Oct 31, 2019

Hallo @jtran1209, thanks for your contribution. We cannot have unpinned dependencies. Which issue are you experiencing? Would downgrading jpype instead be a feasible solution for you?

@ofek
Copy link
Contributor

ofek commented Nov 9, 2019

@jtran1209 Thanks for the heads-up! We actually just merged a patch for this that will ship in 6.16: DataDog/datadog-agent#4402

@ofek ofek closed this Nov 9, 2019
@jtran1209 jtran1209 deleted the update-jaydebeapi branch November 11, 2019 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants