Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log section in the example configuration file #4885

Merged
merged 3 commits into from
Oct 29, 2019

Conversation

kokliKo
Copy link
Contributor

@kokliKo kokliKo commented Oct 25, 2019

What does this PR do?

Adding the logs integration for Memcached

Motivation

Additional Notes

cc @NBParis

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

mcache/README.md Outdated
# ...

# logs:
# - type: file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've done something weird here, it shows red :S

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hithwen fixed it, likely was a copy paste issue

@NBParis
Copy link

NBParis commented Oct 28, 2019

@hithwen @kokliKo Made a couple updates to match the expected read me format (similar to the other integration) and fix the copy paste issue on the tabs in the yaml format

@FlorianVeaux FlorianVeaux changed the title Memcached integration supports logs Add log section in the example configuration file Oct 29, 2019
Copy link
Member

@FlorianVeaux FlorianVeaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and merging.
The name of the PR is used as is in the changelog for each integration, I changed it to something more changelog-like.

Thanks!

@FlorianVeaux FlorianVeaux merged commit 825a76e into master Oct 29, 2019
@FlorianVeaux FlorianVeaux deleted the nicolasbaissas/memcached branch October 29, 2019 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants