Add version metadata #4874
Merged
Add version metadata #4874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
AlexandreYang
previously approved these changes
Oct 31, 2019
hithwen
force-pushed
the
julia/pg-inventories
branch
from
1849e36
to
e019e57
Compare
ofek
approved these changes
Dec 12, 2019
| 'version.patch': '4', | ||
| 'version.scheme': 'semver', | ||
| } | ||
| assert expected == version |
There was a problem hiding this comment.
(nit) This could be a parameterized test.
Currently if the firs case fail, the following cases are not run.
| db.cursor().fetchone.return_value = ['11nightly3'] | ||
| assert get_version(db) == VersionInfo(11, -1, 3) | ||
| version = parse_version('11nightly3') | ||
| assert version == VersionInfo(11, 0, 0, 'nightly.3') |
There was a problem hiding this comment.
(nit) This could be a parameterized test.
Currently if the firs case fail, the following cases are not run.
| @@ -749,3 +751,4 @@ def check(self, instance): | |||
| self.db.commit() | |||
| except Exception as e: | |||
| self.log.warning("Unable to commit: %s", e) | |||
| self._version = None # We don't want to cache versions between runs to capture minor updates for metadata | |||
There was a problem hiding this comment.
(nit) In this case, maybe we should just pass down the version as method parameter instead of caching it on self._version. Seems easier to understand and less error prone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds inventories to PG, also stop using negative versions for betas
Depends on #4844