-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix no instances case for AgentCheck signature and add more tests #4784
Conversation
Codecov Report
|
datadog_checks_base/datadog_checks/base/checks/openmetrics/base_check.py
Show resolved
Hide resolved
33ebc6d
to
42baacc
Compare
Hence, setting this PR on HOLD to be merged later. |
|
||
Agent 6 signature: | ||
|
||
OpenMetricsBaseCheck(name, init_config, instances, default_instances=None, default_namespace=None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this going to change to single instance in agent 8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, from my discussion with @ofek
But maybe should not mention the signature about Agent 8 in this PR, it's a bit out of scope. What do you think ? We can add it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it's mentioned here: https://github.com/DataDog/integrations-core/pull/4784/files#diff-874d5159f166811f6c78ff097251312cR123. Its ok to leave for later but I don't see a reason not to mention it if we know how its going to be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ofek Is that certain that the signature for Agent 8 will like this ?
Agent 8 signature:
AgentCheck(name, init_config, instance) # one instance
AgentCheck.check() # no more instance argument for check method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the goal
datadog_checks_base/datadog_checks/base/checks/openmetrics/base_check.py
Outdated
Show resolved
Hide resolved
datadog_checks_base/datadog_checks/base/checks/openmetrics/base_check.py
Outdated
Show resolved
Hide resolved
…e_check.py Co-Authored-By: Julia <[email protected]>
…e_check.py Co-Authored-By: Julia <[email protected]>
Changes requested have been addressed
What does this PR do?
Add more tests for agent signature
Fix made to handle this case where instances is not passed when using agent 5 signature
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached