-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[go_expvar] Fix path tag appended to all metrics matching path regex #472
Conversation
0b7f667
to
064835a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM! 👌
One comment on the changelog. Could you update manifest.json
with the version bump too?
go_expvar/CHANGELOG.md
Outdated
@@ -3,6 +3,7 @@ | |||
1.0.2 / Unreleased | |||
================== | |||
|
|||
* [BUGFIX] Fix path tag appended to all metrics matching path regex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you put this line in a new 1.0.3
section? 1.0.2
is what was shipped with 5.14.0
Flipping the attribute 'datadog''agent6' to true installs the agent6 instead of the agent5. Switching it back to false should reverse the operation as long as the agent 5 version is pinned.
What does this PR do?
Fix bug where each path matching the path regex of a metric would be added as a tag when an alias is set.
This would result in something like this :
instead of this :
for this yaml file :
Motivation
Discovered the bug while testing the scheduler in the new agent.
Testing Guidelines
An overview on testing
is available in our contribution guidelines.
Versioning
manifest.json
CHANGELOG.md
Additional Notes
Anything else we should know when reviewing?