-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mechanism to execute setup steps before the first check run #4713
Conversation
Codecov Report
|
That works, but about having a |
Co-Authored-By: FlorianVeaux <[email protected]>
@therve The thing is there could be multiple such functions |
Sure, just call them from the |
initialization() | ||
except Exception: | ||
self.check_initializations.appendleft(initialization) | ||
raise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems this would have a similar effect, if I'm not missing something.
while self.check_initializations:
self.check_initializations[0]()
self.check_initializations.pop(0)
@therve That means users/we would have to override that method, call super, then finally add the real logic. The current way allows us to have appropriately named functions that do exactly one thing and just append it to |
Motivation
We need a way to run things after the
check_id
is set by the Agent, such as submitting configuration metadata