Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add yarn application status mapping #4642

Merged
merged 6 commits into from
Oct 31, 2019
Merged

Add yarn application status mapping #4642

merged 6 commits into from
Oct 31, 2019

Conversation

hithwen
Copy link
Contributor

@hithwen hithwen commented Sep 27, 2019 •
edited
Loading

Adds a configurable service check for yarn application statuses.

Reason: Customer wants to know when an application is killed.

@hithwen hithwen requested review from a team as code owners September 27, 2019 11:21
@codecov
Copy link

codecov bot commented Sep 27, 2019 •
edited
Loading

Codecov Report

Merging #4642 into master will increase coverage by 2.62%.
The diff coverage is 88.09%.

Impacted Files Coverage Δ
yarn/tests/test_yarn.py 98.38% <100%> (ø)
yarn/tests/common.py 100% <100%> (ø)
yarn/datadog_checks/yarn/yarn.py 78.73% <81.48%> (ø)
...checks_dev/tests/plugin/test_environment_runner.py
riakcs/datadog_checks/riakcs/riakcs.py
oracle/tests/test_oracle.py
...r/datadog_checks/openstack_controller/__about__.py
twistlock/datadog_checks/twistlock/twistlock.py
...oller/datadog_checks/openstack_controller/utils.py
istio/tests/test_e2e.py
... and 861 more

AlexandreYang
AlexandreYang reviewed Sep 27, 2019
View reviewed changes
Copy link
Member

@AlexandreYang AlexandreYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should provide a default mapping in this case.

yarn/datadog_checks/yarn/yarn.py Outdated Show resolved Hide resolved
yarn/datadog_checks/yarn/yarn.py Outdated Show resolved Hide resolved
@hithwen
Apply suggestions from code review
264b1f3 
Co-Authored-By: Pierre Guceski <[email protected]>
@hithwen
Copy link
Contributor Author

hithwen commented Oct 2, 2019

Putting on hold: Waiting for customer feedback before releasing this feature

@hithwen hithwen merged commit 49382b3 into master Oct 31, 2019
@hithwen hithwen deleted the julia/yarn-custom-status-mapping branch October 31, 2019 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0k0ms l0k0ms l0k0ms left review comments

@AlexandreYang AlexandreYang Awaiting requested review from AlexandreYang

Assignees
No one assigned
Labels
documentation integration/yarn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hithwen @l0k0ms @AlexandreYang