-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix decumulating bucket on multiple contexts #4446
Conversation
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a small comment on the unit-test part
b336481
to
d98448d
Compare
If you want to include this in rc3, you can still delete & recreate the tag to include it (rc3 hasn't been built yet). |
# hence we remove the "le" tag | ||
hash_dict = tags.copy() | ||
del hash_dict["le"] | ||
return hash(frozenset(sorted(iteritems(hash_dict)))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def _compute_bucket_hash(self, tags):
# we need the unique context for all the buckets
# hence we ignore the `le` tag
return hash(frozenset(sorted((k, v) for k, v in iteritems(tags) if k != 'le')))
* Fix decumulating bucket on multiple contexts * Add test for hash tag order
What does this PR do?
Fix overidding buckets when they have different tag context
Motivation
Support histograms having a cardinality > 1
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached