Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly ignore kube_pod_created and kube_pod_container_info #4435

Merged
merged 2 commits into from
Aug 26, 2019
Merged

Properly ignore kube_pod_created and kube_pod_container_info #4435

merged 2 commits into from
Aug 26, 2019

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Aug 26, 2019

No description provided.

@ofek ofek requested review from a team as code owners August 26, 2019 16:58
@ofek ofek merged commit 507e759 into master Aug 26, 2019
@ofek ofek deleted the ofek-patch-1 branch August 26, 2019 17:36
ChristineTChen pushed a commit that referenced this pull request Aug 26, 2019
@ofek @ChristineTChen
Properly ignore kube_pod_created and kube_pod_container_info (#4435)
bbeb095 
* Properly ignore `kube_pod_created` and `kube_pod_container_info`

* fix tests
@codecov
Copy link

codecov bot commented Aug 27, 2019 •
edited
Loading

Codecov Report

Merging #4435 into master will increase coverage by 4.76%.
The diff coverage is 100%.

Impacted Files Coverage Δ
...atadog_checks/kubernetes_state/kubernetes_state.py 79.02% <ø> (ø)
kubernetes_state/tests/test_kubernetes_state.py 95.94% <100%> (ø)
windows_service/tests/common.py
disk/datadog_checks/disk/__init__.py
datadog_checks_base/tests/test_similar.py
win32_event_log/tests/test_check.py
...service/datadog_checks/windows_service/__init__.py
..._checks_base/datadog_checks/base/checks/network.py
...adog_checks_base/datadog_checks/base/utils/date.py
...ent_log/datadog_checks/win32_event_log/__init__.py
... and 131 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaj hkaj hkaj approved these changes

Assignees
No one assigned
Labels
integration/kubernetes_state
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ofek @hkaj