Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min_disk_size option #4317

Merged
merged 8 commits into from
Aug 23, 2019
Merged

Add min_disk_size option #4317

merged 8 commits into from
Aug 23, 2019

Conversation

agottlie
Copy link
Contributor

@agottlie agottlie commented Aug 6, 2019

What does this PR do?

Adds the ability to configure the minimum disk size threshold for devices from which to pull metrics.

Motivation

Client Request.

disk/datadog_checks/disk/data/conf.yaml.default Outdated Show resolved Hide resolved
disk/datadog_checks/disk/disk.py Outdated Show resolved Hide resolved
disk/datadog_checks/disk/disk.py Outdated Show resolved Hide resolved
ruthnaebeck
ruthnaebeck previously approved these changes Aug 21, 2019
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for docs

Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agottlie Thanks for this! I pushed a few commits to fix CI and reverted the legacy path update since I'm about to remove that.

@ofek ofek changed the title add min_disk_size Add min_disk_size option Aug 23, 2019
@ofek ofek merged commit 090d897 into master Aug 23, 2019
@ofek ofek deleted the andrew/disk_min_value branch August 23, 2019 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants