Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix http invert without explicit default #4277

Merged
merged 1 commit into from
Aug 2, 2019

Conversation

AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented Aug 1, 2019

What does this PR do?

Fix http invert without explicit default.

Motivation

Inverting the default defined in http.py for boolean seems semantically more correct when invert is used in remapper.

However, when using HTTP_CONFIG_REMAPPER, it's better to provide an explicit default along with invert.

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

Copy link
Contributor

@therve therve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@AlexandreYang AlexandreYang merged commit 4349b23 into master Aug 2, 2019
@AlexandreYang AlexandreYang deleted the alex/http_invert_default branch August 7, 2019 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants