Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for specifying extra headers in RequestsWrapper #4208

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Add option for specifying extra headers in RequestsWrapper #4208

merged 1 commit into from
Jul 25, 2019

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Jul 25, 2019

Additional Notes

Also added the User-Agent as a default header

@ofek ofek requested review from a team as code owners July 25, 2019 18:03
@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #4208 into master will increase coverage by 1.6%.
The diff coverage is 100%.

Impacted file tree graph

Impacted Files Coverage Δ
...adog_checks_base/datadog_checks/base/utils/http.py 100% <100%> (ø) ⬆️
...g_checks_base/datadog_checks/base/utils/headers.py 57.14% <100%> (+57.14%) ⬆️
datadog_checks_base/tests/test_http.py 98.16% <100%> (+0.04%) ⬆️
...ks_base/datadog_checks/base/stubs/datadog_agent.py 93.75% <100%> (+0.89%) ⬆️
exchange_server/tests/test_exchange_server.py
disk/datadog_checks/disk/__init__.py
...checks_dev/tests/plugin/test_environment_runner.py
.../datadog_checks/windows_service/windows_service.py
datadog_checks_dev/datadog_checks/dev/warn.py
datadog_checks_dev/tests/common.py
... and 83 more

ChristineTChen
ChristineTChen approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@ChristineTChen ChristineTChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ofek ofek merged commit fb02d41 into master Jul 25, 2019
@ofek ofek deleted the ofek/h branch July 25, 2019 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristineTChen ChristineTChen ChristineTChen approved these changes

Assignees
No one assigned
Labels
integration/datadog_checks_base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ofek @ChristineTChen