Fix regression in assert_metric for value comparison #4076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandreYang
force-pushed
the
alex/fix_regression_similar_metrics
branch
from
d95a8ed
to
cee8a7a
Compare
Codecov Report
@@ Coverage Diff @@
## master #4076 +/- ##
==========================================
+ Coverage 81.18% 88.71% +7.52%
==========================================
Files 127 365 +238
Lines 7081 20967 +13886
Branches 879 2194 +1315
==========================================
+ Hits 5749 18601 +12852
- Misses 1117 1806 +689
- Partials 215 560 +345 |
therve
approved these changes
Jul 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fix regression in assert_metric for value comparison
Motivation
Caused failure of this build https://travis-ci.com/DataDog/integrations-core/builds/118355293