Use the new RequestsWrapper for connecting to services #4057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4057 +/- ##
==========================================
- Coverage 86.8% 86.04% -0.76%
==========================================
Files 745 7 -738
Lines 39168 172 -38996
Branches 4613 22 -4591
==========================================
- Hits 33999 148 -33851
+ Misses 3958 15 -3943
+ Partials 1211 9 -1202 |
|
Added changelog/changed since this is removing existing config options |
hithwen
approved these changes
Jul 8, 2019
hithwen
approved these changes
Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Standardize configuration, esp. for proxy behavior