Avoid WMISampler inheriting from Thread #4051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandreYang
commented
Jul 5, 2019
| self.start() | ||
| thread = Thread(target=self._query_sample_loop, name=class_name) | ||
| thread.daemon = True | ||
| thread.start() |
There was a problem hiding this comment.
setDaemon is an old API: https://docs.python.org/2/library/threading.html#threading.Thread.setDaemon
AlexandreYang
commented
Jul 5, 2019
| self.start() | ||
| thread = Thread(target=self._query_sample_loop, name=class_name) | ||
| thread.daemon = True | ||
| thread.start() |
There was a problem hiding this comment.
Starting a thread in the __init__ feels not great. Let me know if you know a better way.
There was a problem hiding this comment.
Start it in sample the first time is called?
There was a problem hiding this comment.
Would make the code a bit more complex though, one more flag to manage.
derekwbrown
approved these changes
Jul 5, 2019
FlorianVeaux
approved these changes
Jul 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Avoid WMISampler inheriting from Thread.
Improvement to this PR: https://github.com/DataDog/integrations-core/pull/3987/files
Revert this PR: #4043
Motivation
No need to inherit Thread.
See also: #3987 (comment)
Additional Notes
/
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached