Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct service check for ksm - cronjob #3937

Merged
merged 2 commits into from
Jun 19, 2019
Merged

Correct service check for ksm - cronjob #3937

merged 2 commits into from
Jun 19, 2019

Conversation

dabcoder
Copy link
Contributor

@dabcoder dabcoder commented Jun 19, 2019 •
edited
Loading

What does this PR do?

Follow up to #3903. Picks the correct service check for ksm (cronjob).

Motivation

Customer request.

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@dabcoder dabcoder requested review from a team as code owners June 19, 2019 10:39
@Simwar
Copy link
Contributor

Simwar commented Jun 19, 2019

👍

@FlorianVeaux FlorianVeaux merged commit d910b3a into master Jun 19, 2019
@FlorianVeaux FlorianVeaux deleted the davidb/service-checks-coredns-ksm branch June 19, 2019 14:10
@l0k0ms l0k0ms mentioned this pull request Nov 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaj hkaj hkaj approved these changes

@FlorianVeaux FlorianVeaux FlorianVeaux approved these changes

Assignees
No one assigned
Labels
integration/kubernetes_state
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dabcoder @Simwar @hkaj @FlorianVeaux